Fix linux special keycodes interpreted as input strings #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue where our Linux input handling was treating special keycodes (like arrow keys, function keys, etc.) as regular input strings. This was causing some weird behavior when users tried to use these keys.
To fix this, I made a couple of changes:
In cdp_patches/input/init.py, I updated the LinuxKeyboardCodes class to wrap all special keycodes in double angle brackets (<<>>). This helps distinguish them from regular text input.
In cdp_patches/input/os_base/linux.py, I modified the send_keystrokes method to recognize these new wrapped keycodes. It now strips off the <<>> before processing the keycode.
These changes should make our input handling more consistent across different operating systems and prevent special keys from being typed out as literal strings.