Added sweeping resonances #516
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerlz
requested changes
Jan 13, 2025
Comment on lines
+2238
to
+2239
| # The default is 1.2 sec which is a good all-round choice. | ||
| # It is disabled by default as it tends to create issues on certain setups. |
There was a problem hiding this comment.
the default is 1.2 seconds and the default is disabled?
There was a problem hiding this comment.
remove the biased sentence: as it tends to create issues on certain setups.
| the default settings). The new test should generally produce more | ||
| accurate and reliable test results. However, if required, the previous | ||
| test behavior can be restored by adding options `sweeping_period: 0` and | ||
| `accel_per_hz: 75` to the `[resonance_tester]` config section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added Klipper3d/klipper#6723
Checklist