Initial run of a py.test collector for the existing klippy .test format, rework CI to do more validation
#503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kageurufu
force-pushed
the
pytest
branch
4 times, most recently
from
776f51c to
2e44887
Compare
kageurufu
changed the title
.test format.test format, rework CI to do more validation
Gcode unknown commands and command errors are now test exceptions
`ASSERT TEST="{printer.whatever} is False"` in tests allows template
evaluated runtime assertions
fix a couple broken tests that did not error because of the above
If there are changes that may affect the firmware, rebuild the docker image (Pull the existing image first to re-use the layer cache) Klippy changes, test across all supported python versions
- Build and push the docker image on pushes to main - Ensure scripts/*requirements*.txt are up to date - Separate python versions into individual steps for better clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a compatible collector for py.test to run
test/klippy/*.testfiles. This is effectively identical to running them usingscripts/test_klippy.pywhich I did not yet remove.As well, add
test/test_imports.pyto get actual errors from importsChecklist