Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move requirements to pyproject.toml #502

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Move requirements to pyproject.toml #502

merged 3 commits into from
Jan 7, 2025

Conversation

kageurufu
Copy link
Member

Set up enough of pyproject.toml to be valid as a project

We already effectively had a minimum python version of 3.9 (due to dependencies), this merely notes that.

regenerating scripts/klippy-requirements.txt and scripts/requirements_dev.txt
can be done with
uv export -o scripts/klippy-requirements.txt --no-hashes --no-dev and
uv export -o scripts/requirements_dev.txt --no-hashes --dev-only (personally, I think we remove requirements_dev.txt soon)

Checklist

  • pr title makes sense
  • squashed to 1 commit
  • added a test case if possible
  • if new feature, added to the readme
  • ci is happy and green

@kageurufu kageurufu requested a review from a team as a code owner December 22, 2024 20:31
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@PhilippMolitor
Copy link
Member

i'd also recommend setting up a .python-version file in the root so uv automatically installs the recommended python version by itself when using uv venv: https://docs.astral.sh/uv/concepts/python-versions/#python-version-files

@kageurufu
Copy link
Member Author

.python-version what would we want? I'm happy to just bless 3.13 there.

The ruff checks, that's a discussion with @rogerlz about what's going to be useful enough to be worth making merging upstream harder

@PhilippMolitor
Copy link
Member

I'd also say 3.13 for the sake of being progressive.

As we still want to merge upstream changes, linting is an issue for sure... no easy route there.

@kageurufu
Copy link
Member Author

kageurufu commented Dec 23, 2024 via email

@PhilippMolitor
Copy link
Member

also, do we want to move pyproject.toml and uv.lock to the klippy folder maybe? this way they are semantically not responsible for all of the codebase, but just klippy. this would also simplify my effort (not yet committed) to add a seperate pyproject for the docs.

Set up enough of pyproject.toml to be valid as a project

We already effectively had a minimum python version of 3.9
(due to dependencies), this change merely denotes that.

regenerating `scripts/klippy-requirements.txt` and `scripts/requirements_dev.txt`
 can be done with
 `uv export -o scripts/klippy-requirements.txt --no-hashes` and
 `uv export -o scripts/requirements_dev.txt --no-hashes --dev-only`
Add cffi and greenlet pins for 3.13
@rogerlz rogerlz merged commit a6b7a38 into main Jan 7, 2025
3 checks passed
@rogerlz rogerlz deleted the pyproject_uv branch January 7, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants