-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move requirements to pyproject.toml #502
Conversation
i'd also recommend setting up a |
.python-version what would we want? I'm happy to just bless 3.13 there. The ruff checks, that's a discussion with @rogerlz about what's going to be useful enough to be worth making merging upstream harder |
I'd also say 3.13 for the sake of being progressive. As we still want to merge upstream changes, linting is an issue for sure... no easy route there. |
So I think we make a discord thread for linting, I'll add .python-version,
and this is good to merge.
Maybe update ci-install to use uv
Sent with Shortwave
<https://www.shortwave.com?utm_medium=email&utm_content=signature&utm_source=ZnJhbmtseW5AdGFja2l0dC5uZXQ=>
On Mon Dec 23, 2024, 04:52 PM GMT, Philipp Molitor ***@***.***> wrote:
I'd also say 3.13 for the sake of being progressive.
As we still want to merge upstream changes, linting is an issue for sure...
no easy route there.
—
Reply to this email directly, view it on GitHub
<#502 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB7NJ2W5SZRUMXSNZJTIZT2HA5VDAVCNFSM6AAAAABUB62STOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRQGAZDCNZQGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
also, do we want to move pyproject.toml and uv.lock to the klippy folder maybe? this way they are semantically not responsible for all of the codebase, but just klippy. this would also simplify my effort (not yet committed) to add a seperate pyproject for the docs. |
Set up enough of pyproject.toml to be valid as a project We already effectively had a minimum python version of 3.9 (due to dependencies), this change merely denotes that. regenerating `scripts/klippy-requirements.txt` and `scripts/requirements_dev.txt` can be done with `uv export -o scripts/klippy-requirements.txt --no-hashes` and `uv export -o scripts/requirements_dev.txt --no-hashes --dev-only`
Add cffi and greenlet pins for 3.13
Set up enough of pyproject.toml to be valid as a project
We already effectively had a minimum python version of 3.9 (due to dependencies), this merely notes that.
regenerating
scripts/klippy-requirements.txt
andscripts/requirements_dev.txt
can be done with
uv export -o scripts/klippy-requirements.txt --no-hashes --no-dev
anduv export -o scripts/requirements_dev.txt --no-hashes --dev-only
(personally, I think we remove requirements_dev.txt soon)Checklist