Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile #18

Closed
wants to merge 1 commit into from
Closed

Add Dockerfile #18

wants to merge 1 commit into from

Conversation

jmc000
Copy link
Contributor

@jmc000 jmc000 commented Mar 20, 2023

Hey folks, I submit this small PR for adding a Dockerfile to your repo in the name of the Node Guardians team!

Since we build our own docker image in our deployment stack, we thought it may be usefull to contribute and share it with you and the community :)


  • adding Dockerfile
  • add make targets for building distroless root, nonroot, root-debug and nonroot-debug images
  • update README.md

@johnletey
Copy link
Member

Hey @jmc000 - thanks for your PR 🔥

As part of our next release (v1.1), we are going to look into reproducible builds.
So we will revisit this PR in the coming weeks!

@johnletey
Copy link
Member

Hey @jmc000 - just wanted to update you that this has been postponed to v1.2

However, we have not forgotten about it 🤝

@shifty11 shifty11 mentioned this pull request Oct 9, 2023
@mbreithecker
Copy link
Member

Hey @jmc000
my apologies for the delay on this PR. The delay was primarily due to our team prioritizing other tasks over Docker support. We aim to ensure that each feature we incorporate receives the necessary attention and resources for continued support and maintenance.

This is now the case and your commit is included in #128 which will then also close your PR.

Thank you for your patience and contributions. We truly appreciate your efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants