-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automatically halt pool if a node's voting power is too high #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shifty11
suggested changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you merge the new v1.4 branch into this one (rapha/funders-module)?
Because there were so many changes especially for the tests.
mbreithecker
previously approved these changes
Nov 6, 2023
shifty11
approved these changes
Nov 6, 2023
mbreithecker
approved these changes
Nov 6, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
) (cherry picked from commit 1aaf221)
mbreithecker
pushed a commit
that referenced
this pull request
Nov 7, 2023
…ackport #142) (#143) Co-authored-by: Troy Kessler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relevant implementations can be found in:
proto/kyve/pool/v1beta1/pool.proto
x/bundles/keeper/logic_bundles.go
x/query/keeper/helper.go
Many test changes where necessary, because it is not possible anymore that only one staker runs in a pool. Because many tests only had one staker, almost all (especially in the bundles module) had to be adjusted