Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically halt pool if a node's voting power is too high #142

Merged
merged 26 commits into from
Nov 6, 2023

Conversation

troykessler
Copy link
Member

@troykessler troykessler commented Oct 30, 2023

The relevant implementations can be found in:

  • proto/kyve/pool/v1beta1/pool.proto
  • x/bundles/keeper/logic_bundles.go
  • x/query/keeper/helper.go

Many test changes where necessary, because it is not possible anymore that only one staker runs in a pool. Because many tests only had one staker, almost all (especially in the bundles module) had to be adjusted

Copy link
Contributor

@shifty11 shifty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge the new v1.4 branch into this one (rapha/funders-module)?
Because there were so many changes especially for the tests.

mbreithecker
mbreithecker previously approved these changes Nov 6, 2023
@mbreithecker mbreithecker added the backport/v1.4.x backport patches to v1.4.x branch label Nov 6, 2023
@mbreithecker mbreithecker merged commit 1aaf221 into main Nov 6, 2023
4 checks passed
@mbreithecker mbreithecker deleted the feat/dynamic-min-delegation branch November 6, 2023 16:04
mergify bot pushed a commit that referenced this pull request Nov 6, 2023
mbreithecker pushed a commit that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v1.4.x backport patches to v1.4.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants