feat: store stake security for finalized bundles #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troykessler
approved these changes
Jul 11, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
(cherry picked from commit c5183cf)
mbreithecker
added a commit
that referenced
this pull request
Jul 12, 2023
Co-authored-by: Maximilian Breithecker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For every bundle finalised, KYVE will now also store the total amount of stake that voted for a given bundle and the total amount of stake which was present during the bundle finalisation.
These two properties are key values as they represent the security of the given bundle.
For off-chain analysis this data can already be obtained through the events. However, this will become relevant in the future, when one needs to access these values on-chain.