feat: improved schema for finalized bundles query #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbreithecker
added
backport/v1.0.x
# Conflicts: # proto/kyve/bundles/v1beta1/bundles.proto # x/bundles/types/bundles.pb.go # x/bundles/types/keys.go
mbreithecker
removed
backport/v1.0.x
troykessler
approved these changes
Jul 10, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
(cherry picked from commit cf4857f)
mergify bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
(cherry picked from commit cf4857f) # Conflicts: # CHANGELOG.md # app/upgrades/v1_3/upgrade.go # proto/kyve/bundles/v1beta1/bundles.proto # x/bundles/types/bundles.pb.go # x/bundles/types/keys.go
This was referenced Jul 10, 2023
mbreithecker
added a commit
that referenced
this pull request
Jul 11, 2023
Co-authored-by: Maximilian Breithecker <[email protected]>
mbreithecker
added a commit
that referenced
this pull request
Jul 11, 2023
Co-authored-by: Maximilian Breithecker <[email protected]> Co-authored-by: mbreithecker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to handle the responses for multiple versions of the raw stored finalized bundles.
It also renames the verbose endpoints
kyve/query/v1beta1/finalized_bundle/{pool_id}tokyve/v1/bundles/{pool_id}andkyve/query/v1beta1/finalized_bundle/{pool_id}/{id}tokyve/v1/bundles/{pool_id}/{id}.This change will be back-ported to all versions so that all versions will always have the latests schema.