Skip to content

Commit

Permalink
chore: implemented feedback from coderabbit
Browse files Browse the repository at this point in the history
  • Loading branch information
troykessler committed May 14, 2024
1 parent 66a8651 commit a1d0bfa
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 27 deletions.
32 changes: 15 additions & 17 deletions docs/static/openapi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@ paths:
type: integer
format: int64
description: >-
storage_provider_id is a unique id for each storage
provider like Arweave, Irys, Filecoin etc...
storage_provider_id is a unique identifier for each
storage provider, such as Arweave, Irys, Filecoin,
etc.
cost:
type: string
title: >-
description: >-
cost is the amount in USD to store one byte on the
storage provider and should be kept up-to-date.
The unit of this is USD/byte
storage provider. This value should be kept
up-to-date.
title: StorageCost defines the cost for storage providers
description: storage_costs ...
network_fee:
Expand Down Expand Up @@ -4430,15 +4430,15 @@ paths:
type: integer
format: int64
description: >-
storage_provider_id is a unique id for each storage
provider like Arweave, Irys, Filecoin etc...
storage_provider_id is a unique identifier for each
storage provider, such as Arweave, Irys, Filecoin,
etc.
cost:
type: string
title: >-
description: >-
cost is the amount in USD to store one byte on the
storage provider and should be kept up-to-date.
The unit of this is USD/byte
storage provider. This value should be kept
up-to-date.
title: StorageCost defines the cost for storage providers
description: storage_costs ...
network_fee:
Expand Down Expand Up @@ -4735,14 +4735,12 @@ paths:
that needs to be funded per bundle
coin_weight:
type: string
title: >-
description: >-
coin_weight is a factor used to sort funders after
their funding amounts.
This should be the market price of that coin in
USD/coin and should be
kept up-to-date
This should be the market price of the coin in
USD/coin. This value should be kept up-to-date.
title: >-
WhitelistCoinEntry is an object containing information
around a coin which
Expand Down
5 changes: 2 additions & 3 deletions proto/kyve/bundles/v1beta1/params.proto
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,9 @@ option go_package = "github.com/KYVENetwork/chain/x/bundles/types";

// StorageCost defines the cost for storage providers
message StorageCost {
// storage_provider_id is a unique id for each storage provider like Arweave, Irys, Filecoin etc...
// storage_provider_id is a unique identifier for each storage provider, such as Arweave, Irys, Filecoin, etc.
uint32 storage_provider_id = 1;
// cost is the amount in USD to store one byte on the storage provider and should be kept up-to-date.
// The unit of this is USD/byte
// cost is the amount in USD to store one byte on the storage provider. This value should be kept up-to-date.
string cost = 2 [
(gogoproto.customtype) = "cosmossdk.io/math.LegacyDec",
(gogoproto.nullable) = false
Expand Down
3 changes: 1 addition & 2 deletions proto/kyve/funders/v1beta1/params.proto
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ message WhitelistCoinEntry {
// that needs to be funded per bundle
uint64 min_funding_amount_per_bundle = 3;
// coin_weight is a factor used to sort funders after their funding amounts.
// This should be the market price of that coin in USD/coin and should be
// kept up-to-date
// This should be the market price of the coin in USD/coin. This value should be kept up-to-date.
string coin_weight = 4 [
(gogoproto.customtype) = "cosmossdk.io/math.LegacyDec",
(gogoproto.nullable) = false
Expand Down
5 changes: 2 additions & 3 deletions x/bundles/types/params.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions x/funders/types/params.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a1d0bfa

Please sign in to comment.