-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/redis user repository #5
Conversation
public class RedisUserController implements UserController{ | ||
|
||
private final UserService userService; | ||
|
||
@PostMapping("/user") | ||
@PostMapping(produces= MediaType.APPLICATION_JSON_VALUE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어노테이션에 해당 값을 넣은 이유가 뭔가요? json으로 받는 것만을 명시하기 위해서인가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
잘해주고 있는거 같아 다행입니다. 남은 구현도 파이팅입니다.
return redisOperations.opsForValue() | ||
.set(user.getKey(),user) | ||
.then(Mono.just(user.getKey())) | ||
.flatMap(key->redisOperations.opsForValue().get(key)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flatMap을 사용한 것이 인상이 깊네요. 만약 정상적으로 처리되었는지 정도만의 처리라면 Boolean 정도만으로도 충분해 보이는거 같아요
…into feat/RedisUserRepository
Test Results9 tests 9 ✅ 1s ⏱️ Results for commit 563fe30. |
✏️ 작업 개요
⛳ 작업 분류
🔨 작업 상세 내용
💡 생각해볼 문제
💣 trouble