-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(KUI-1166): upgrade dependencies (react-pdf etc) and cleanup config #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and install npm version of react-pdf Overriding restructure was needed because of this issue: diegomura/react-pdf#2675
…ion=absolute), also fix layout within footer
…t via overrides. See issue: diegomura/react-pdf#2725
karlandindrakryggen
force-pushed
the
issues/KUI-1166-react-pdf
branch
from
July 31, 2024 13:53
353a3fe
to
b338352
Compare
karlandindrakryggen
force-pushed
the
issues/KUI-1166-react-pdf
branch
from
August 6, 2024 14:35
7db3e46
to
949ff51
Compare
karlandindrakryggen
changed the title
Issues/k UI 1166 react pdf
feat(KUI-1166): upgrade react-pdf
Aug 7, 2024
karlandindrakryggen
changed the title
feat(KUI-1166): upgrade react-pdf
feat(KUI-1166): upgrade dependencies (react-pdf etc) and cleanup config
Aug 7, 2024
karlandindrakryggen
requested review from
belanglos,
amirhossein-haerian,
axelbjo and
allazis
as code owners
August 7, 2024 05:41
amirhossein-haerian
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⭐️
Well done with this task 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade misc dependencies and cleanup eslint config.
react-pdf isn't upgrade to latest version due to memory issue. Read more in KUI-1379.