Set git safe.directory in meta tester #3766
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See KSP-CKAN/NetKAN#9527; the metadata tester is broken, but that attempt has not fixed the problem.
Causes
Probing the docker image, I have slightly more confirmation now that this relates somehow to the permissions of the git repo (see the later comments in KSP-CKAN/NetKAN#9527).
However, there's a big gap in this explanation: NOTHING CHANGED. It's using the same old version of
git
, GitPython is probably the same, and our code is the same. For this to start happening when it did would imply that GitHub made some change to how Actions handle permissions right at the moment when we were rebuilding this docker image. So 🤷.Changes
Now the Dockerfile for the meta tester sets git's
safe.directory
setting to*
, which should allow our code to access the repo regardless of the mess that the GitHub Actions framework makes of the ownership or permissions.I'll self-review this because it's low risk (the thing is already broken) and I want to test it right away.