-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Italian language #818
Conversation
Created and added the Italian language
Oh, by reviewing the file I've noticed that the indentation of my line was made with a tab instead of spaces like other lines. On my editor it was graphically the same so I didn't noticed, thanks to point out. |
|
Copy and paste to l10n.dart |
Corrected the wrong TAB in i10n.dart and added translations of new text items
No, it was me... I had no time and did it quickly. Sorry, now it's fixed. |
@energywave There is another PR with italian translation: #676 |
Yeah, I've noticed after the creation of my PR :( Damn, I could simply complete that PR instead of reinventing the wheel but I didn't think to search for Italian language open PR... My fault. |
I don't care about credits :) |
If I could continue the work started by me and @OpenCode , it wouldn't be bad. |
Added suggestions as in comments of PR KRTirtho#676 and added credits to @ncvescera and @OpenCode
@energywave Can you adapt this PR with the terms from the discussion on the other one so we can close it? |
My commit just before your comment was just what you're asking. I've inserted all the suggestions from the other discussion as stated in the commit title. |
Ok. This PR is synced and ready to merge (I've resolved the merge conflicts that was origintating from the turkish translation). |
Great work everyone and also @ncvescera. |
I've added Italian language as instructed in CONTRIBUTION.md.
I'm not a flutter developer so I tried to install and compile Spotube to test it but it was overkill and I had two errors (the first about app_ar.arb file (not mine), the second about abstract class .env)
Sorry but I decided to open a PR without having tested it. The translation is there and I can check in your compiled dev version if that's all ok or not.
I'm available to check and modify something if needed, just don't have so much time to create a working flutter environment.