Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic support for iOS, fix missing Rust lib #259

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Basic support for iOS, fix missing Rust lib #259

merged 1 commit into from
Oct 14, 2022

Conversation

karniv00l
Copy link
Contributor

@karniv00l karniv00l commented Oct 8, 2022 •
edited
Loading

Related to: #173

Only tested on simulator right now.

Screenshot 2022-10-13 at 19 44 50

Issues:

  • download doesn't work (at least in simulator)
  • playback bar covers bottom menu
  • super weird scrolling / swiping behavior (up/down) - practically unusable (at least in the simulator), I guess this is the change with the Flutter's ios/macos drag physics

karniv00l
karniv00l commented Oct 8, 2022
View reviewed changes
pubspec.yaml
Comment on lines +55 to +58
metadata_god:
git:
url: https://github.com/KRTirtho/metadata_god.git
ref: 7d195fdde324b382fc12067c56391285807e6233
Copy link
Contributor Author

@karniv00l karniv00l Oct 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the last working commit

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this commit I guess MacOS wasn't working. Does the MacOS application work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the library on macOS, after this commit it breaks (it can't find the compiled library anymore)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah.. my bad. It's actually the latest commit 😅

@KRTirtho
Copy link
Owner

KRTirtho commented Oct 10, 2022 •
edited
Loading

playback overlay covers bottom menu

It is fixed now. Thanks to the new ShellRoute API of go_router. Now it's a part of the bottomNavigationBar. Both will show everywhere except Login Page and PlayerView

@karniv00l
Copy link
Contributor Author

It is fixed now. Thanks to the new ShellRoute API of go_router. Now it's a part of the bottomNavigationBar. Both will show everywhere except Login Page and PlayerView

rebased

@KRTirtho KRTirtho merged commit 83792bd into KRTirtho:master Oct 14, 2022
@KRTirtho
Copy link
Owner

Thanks man. Great job ❤️🚀

@karniv00l karniv00l deleted the ios branch October 14, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KRTirtho KRTirtho KRTirtho left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karniv00l @KRTirtho