Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When dragging the volume slider, have volume update in real time, instead of only on release. #520

Closed
1 task done
octia opened this issue May 31, 2023 · 10 comments
Closed
1 task done
Labels
enhancement New feature or request macOS macOS related issue
Milestone

Comments

@octia
Copy link

octia commented May 31, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Pain

I'm dragging the volume slider, and I don't know what is the volume that I'm gonna end up on, before I release the slider. This means I need to release it and then grab it again to drag it again, to get the volume I want.

Suggested solution

Have it update on every change, not only on release.

Useful resources

No response

Additional information

No response

@octia octia added the enhancement New feature or request label May 31, 2023
@KRTirtho
Copy link
Owner

Available on nightly

@KRTirtho KRTirtho moved this to Done in Spotube Board Jun 11, 2023
@KRTirtho KRTirtho added this to the Version 3.0.0 milestone Jun 11, 2023
@RaptaG
Copy link
Contributor

RaptaG commented Jul 2, 2023

Fixed in 3.0.0

@RaptaG RaptaG closed this as completed Jul 2, 2023
@RaptaG RaptaG moved this from Done to Deployed in Spotube Board Jul 2, 2023
@RaptaG RaptaG added the deployed This issue has been fixed/implmented and has been released label Jul 2, 2023
@Traace
Copy link

Traace commented Jul 11, 2023

With Version 3.0.0 the volume slider is missing completly....

@RaptaG
Copy link
Contributor

RaptaG commented Jul 11, 2023

With Version 3.0.0 the volume slider is missing completly....

It is not, not on my end

@karniv00l
Copy link
Contributor

@KRTirtho VolumeSlider is rendered here:

https://github.com/KRTirtho/spotube/blob/master/lib/components/root/bottom_player.dart#L119

and default fullWidth = false, so it doesn't render full slider on a desktop:

if (fullWidth) Expanded(child: slider) else slider,

also this actually renders app as a blank window for me in debug mode with messages like RenderBox was not laid out. Looks like it needs a container here

@KRTirtho
Copy link
Owner

KRTirtho commented Jul 11, 2023

It renders for me though. Also no renderbox exception in both debug and release mode. Is it a mac-only issue then?
image

Windows, Android, Linux works fine. Couldn't test mac

@karniv00l
Copy link
Contributor

karniv00l commented Jul 11, 2023

Oh I see: https://api.flutter.dev/flutter/material/Slider/Slider.adaptive.html
creates Cupertino slider, which probably is a culprit

I would personally stay away from Cupertino widgets when most of the app is material anyway

Just to summarize, currently on mac (release mode) it looks like this:

Screenshot 2023-07-11 at 16 08 03

@karniv00l
Copy link
Contributor

so something like this would be nice:

Screenshot 2023-07-11 at 16 05 34

@KRTirtho
Copy link
Owner

Oh that makes total sense. This is actually why I also dropped platform_ui for Spotube primarily 😄

Lesson learned, stay away from platform adaptive widgets (for now) 😅

@KRTirtho KRTirtho reopened this Jul 11, 2023
@github-project-automation github-project-automation bot moved this from Deployed to In progress in Spotube Board Jul 11, 2023
@KRTirtho KRTirtho added macOS macOS related issue and removed deployed This issue has been fixed/implmented and has been released labels Jul 11, 2023
KRTirtho added a commit that referenced this issue Jul 11, 2023
@KRTirtho KRTirtho added the deployed This issue has been fixed/implmented and has been released label Jul 11, 2023
@KRTirtho KRTirtho moved this from In progress to Done in Spotube Board Jul 11, 2023
@KRTirtho KRTirtho removed the deployed This issue has been fixed/implmented and has been released label Jul 11, 2023
@KRTirtho
Copy link
Owner

The app is now alien in all platforms equally 😂

@KRTirtho KRTirtho moved this from Done to Deployed in Spotube Board Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request macOS macOS related issue
Projects
Status: Deployed
Development

No branches or pull requests

5 participants