Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/seoro #15

Merged
merged 4 commits into from
Feb 25, 2024
Merged

Dev/seoro #15

merged 4 commits into from
Feb 25, 2024

Conversation

okxooxoo
Copy link
Contributor

'양재역' 검색 결과 Drawer에 주변 맛집 카드 UI가 생성됩니다.
가게의 별점이랑 사진은 아직 반영하지 않았습니다.

스크린샷 2024-02-21 오전 10 38 00

Copy link
Collaborator

@LuticaCANARD LuticaCANARD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전반적으로 잘하셨어요! 다만 컴포넌트 관련해서 수정하는게 버그 잡기나 가독성면에서 수월할 것 같아요

src/ui/drawer.tsx Outdated Show resolved Hide resolved
src/ui/MapNodeCard.tsx Outdated Show resolved Hide resolved
src/ui/MapNodeCard.tsx Outdated Show resolved Hide resolved
src/service/search.ts Show resolved Hide resolved
src/service/MapObject/MapNode.ts Show resolved Hide resolved
Copy link

cloudflare-workers-and-pages bot commented Feb 24, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 26b462f
Status: ✅  Deploy successful!
Preview URL: https://73574393.pick-of-pig.pages.dev
Branch Preview URL: https://dev-seoro.pick-of-pig.pages.dev

View logs

@okxooxoo
Copy link
Contributor Author

모두 반영 완료 + 가게의 점수에 따라 MapNodeCard의 별 개수도 바뀝니다.

@LuticaCANARD LuticaCANARD merged commit bd321aa into main Feb 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants