Fix off() method in RGB #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since animate() method doesn't call self.show() when RGB is toggled off, it has to be called in the self.off() for the latter to produce desired effect.
|
this fixes issue #904 |
xs5871
approved these changes
Oct 22, 2023
hixan
pushed a commit
to hixan/kmk_firmware
that referenced
this pull request
Nov 25, 2023
* Fix off() method in RGB Since animate() method doesn't call self.show() when RGB is toggled off, it has to be called in the self.off() for the latter to produce desired effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the animate() method doesn't call
self.show()when RGB is toggled off, it has to be called inself.off()for the latter to produce desired effect.