Added extra construction support to Encoder.py to support pullup direction from Code.py #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pin_button construction. This includes allowance for pull resistor (pullup/pulldown) customisation directly from code.py. Additionally the change preserves state generation semantics for pin_button.get_value(self) and depends upon the pull direction. The default pull direction remains as digitalio.Pull.UP
xs5871
requested changes
Sep 28, 2023
added 2 commits
September 28, 2023 12:10
…tatement for EncoderPin.get_value() as suggested in review
… button action and was activating upon keyboard USB insertion without user interaction. Fixed this error.
|
On another note: new features require documentation for a merge. |
…in an additional optional argument defaulting to Pull.UP instead of overloading the argument with a tuple. This is tested, and documented in English
xs5871
approved these changes
Oct 18, 2023
hixan
pushed a commit
to hixan/kmk_firmware
that referenced
this pull request
Nov 25, 2023
…ction from Code.py (KMKfw#891) * Added support to Encoder.py to allow GPIOEncoder to accept tuple for pin_button construction. This includes allowance for pull resistor (pullup/pulldown) customisation directly from code.py. Additionally the change preserves state generation semantics for pin_button.get_value(self) and depends upon the pull direction. The default pull direction remains as digitalio.Pull.UP * Replaced multiline ternary/conditional expression with a regular If statement for EncoderPin.get_value() as suggested in review * Prior commit failed test. Audio Mute was assigned to the encoder push button action and was activating upon keyboard USB insertion without user interaction. Fixed this error. * Implemented the reviewer suggestion for the GPIO constructor to take in an additional optional argument defaulting to Pull.UP instead of overloading the argument with a tuple. This is tested, and documented in English * Fix formatting encoder.py --------- Co-authored-by: Gordon Jamieson <[email protected]> Co-authored-by: xs5871 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to Encoder.py to allow GPIOEncoder to accept tuple for pin_button construction. This includes allowance for pull resistor (pullup/pulldown) customisation directly from code.py. Additionally the change preserves state generation semantics for pin_button.get_value(self) and depends upon the pull direction. The default pull direction remains as digitalio.Pull.UP
An example config from code.py to customise the pin button pull up direction:
encoder_handler.pins = ((board.VOLC_A, board.VOLC_B, (board.VOLC_PUSH, True, digitalio.Pull.DOWN), False, 2),)
Tested this out on my own code.py.