-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new high-level credentialing interfaces #811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments here throughout:
- We are moving to issuer as language. This needs to be aligned with the comms team. lets make sure that this happens.
- A few questions to be answered
- The code itself is good, but its hard to know how it will be in production without using it. It will be interesting in the future when we can start implementing it.
- it feels as if we have gone back to the roles model.
True, I chose issuer over attester as this is the language used by the VC specs.
This is mostly for organising the code; but I also export the functions under those actors namespaces right now because I think it helps a lot for understanding what you can do with a credential. But this can be discussed; we can also export it all in one namespace if that's better |
const { byDid, byAlgorithm } = Signers.select | ||
|
||
/** | ||
* Signs a document with a DID-related signer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Signs a document with a DID-related signer. | |
* Signs and updates a document with a new DID-related signer. |
Maybe…?
This should also be noted to comms that we are doing this. I think we were going to collect a bunch of new languages and roll out the change in the SDK version 1. It would be good to identify this so we can offer this for the company to communicate to the community. Regarding the changes it does help with reading and organising the code. I prefer the actors API vibe. It feels more suited towards our communications of how to use the technology. |
I think jour fixe would be a good place to bring this up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes KILTProtocol/ticket#2964
Introduces high-level credentialing interfaces (e.g., issue / createPresentation / verifyPresentation) which are agnostic, on the surface, of which type of credential or proof is being used and provide a seamless experience even when we introduce support for additional proof types.
Some changes to some previously implemented functionality were made as part of this:
DataIntegrity.signWithDid
function; Presentation creation is available as a separate step. A function that combines creation and signing is available in the new holder interfaces.Date
instances throughout.Not covered here:
How to test:
Tests are pending, but all interfaces are being covered in bundle tests.
Checklist: