-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DIP provider type definitions #743
Conversation
a61966d
to
e4c83a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also run type generation and commit the results so we know this still works?
{ | ||
minmax: [11200, undefined], | ||
types: types11200, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we know for sure this is going to be the runtime version with which this is released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we don't. The current release of KILT won't have the provider pallet deployed. The provider template runtime does. Maybe I should move these definitions to the new repo, and add it here only when it's going to be included? Otherwise it's really difficult to test this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mhh yeah maybe this is the way then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metadata V15 is not out yet. V14 only exposes stuff that is directly used by the runtime. The only way to make it work would be to expose a config pallet which exposes to metadata whatever stuff it is passed to its Config
trait. Not sure what the downsides of that would be. For one definitely WASM size.
Putting this on hold until we have a version of our chain that has the provider pallet deployed. Until then, all type augmentation and runtime decoration will happen in the integration tests of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, should we wait with merging until we prepare the release that includes the dip though?
Yes, I put it on hold indeed. I also marked it as draft again to make it clearer. |
* Add type definitions for the new dipSender runtime API * Update types with new spec 11000 * Update type definitions * Change keyIds input type
Rename producer -> provider and receiver -> consumer
Add dipProvider pallet for DID extrinsic signing
* Error types * Update DIP provider runtime APIs types * Update packages version
* Add version type * Set package versions * Fix identity commitment version type
* Draft PR commit * feat: DID merkle proofs (#744) * Add type definitions for the new dipSender runtime API * Update types with new spec 11000 * Update type definitions * Change keyIds input type * chore: support parties renaming (#751) Rename producer -> provider and receiver -> consumer * chore: update types for additional linked info (#759) Update types * feat: add `dipProvider` pallet for DID extrinsic signing (#764) Add dipProvider pallet for DID extrinsic signing * chore: set package version to 0.33.2-dip-0 * feat: error management (#802) * Error types * Update DIP provider runtime APIs types * Update packages version * feat: add versioning support (#806) * Add version type * Set package versions * Fix identity commitment version type * Update lock file * Changes based on KILTprotocol/kilt-node@1e338a4 * Set version to DIP version * Changes based on KILTprotocol/kilt-node@e23dbcc * Update type definitions * Revert package versions change * Revert yarn.lock changes * Set version to dip-2 * Revert package.json changes * Add runtime calls to Peregrine runtimes
Contains all PRs related to DIP, and will be merged at the end of the development iteration for DIP v1.Companion of KILTprotocol/kilt-node#494.Most of the features are under migration to https://github.com/KILTprotocol/dip-sdk.
This PR only contains the type definitions for the DIP provider stuff as exposed in KILTprotocol/kilt-node#494.