Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DIP provider type definitions #743

Merged
merged 18 commits into from
Dec 13, 2023
Merged

feat: DIP provider type definitions #743

merged 18 commits into from
Dec 13, 2023

Conversation

ntn-x2
Copy link
Member

@ntn-x2 ntn-x2 commented Mar 30, 2023

Contains all PRs related to DIP, and will be merged at the end of the development iteration for DIP v1.

Companion of KILTprotocol/kilt-node#494.

Most of the features are under migration to https://github.com/KILTprotocol/dip-sdk.
This PR only contains the type definitions for the DIP provider stuff as exposed in KILTprotocol/kilt-node#494.

@ntn-x2 ntn-x2 self-assigned this Mar 30, 2023
@ntn-x2 ntn-x2 force-pushed the aa/dip branch 3 times, most recently from a61966d to e4c83a5 Compare June 15, 2023 08:39
@ntn-x2 ntn-x2 changed the base branch from develop to vc-refactor November 9, 2023 08:43
@ntn-x2 ntn-x2 changed the title feat: DIP support feat: DIP provider type definitions Nov 15, 2023
@ntn-x2 ntn-x2 changed the base branch from vc-refactor to develop November 15, 2023 14:53
@ntn-x2 ntn-x2 marked this pull request as ready for review November 15, 2023 14:54
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also run type generation and commit the results so we know this still works?

packages/did/src/DidDetails/FullDidDetails.ts Show resolved Hide resolved
Comment on lines +128 to +131
{
minmax: [11200, undefined],
types: types11200,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know for sure this is going to be the runtime version with which this is released?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't. The current release of KILT won't have the provider pallet deployed. The provider template runtime does. Maybe I should move these definitions to the new repo, and add it here only when it's going to be included? Otherwise it's really difficult to test this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhh yeah maybe this is the way then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata V15 is not out yet. V14 only exposes stuff that is directly used by the runtime. The only way to make it work would be to expose a config pallet which exposes to metadata whatever stuff it is passed to its Config trait. Not sure what the downsides of that would be. For one definitely WASM size.

@ntn-x2
Copy link
Member Author

ntn-x2 commented Nov 16, 2023

Putting this on hold until we have a version of our chain that has the provider pallet deployed. Until then, all type augmentation and runtime decoration will happen in the integration tests of the @kiltprotocol/dip-sdk repo.

@ntn-x2 ntn-x2 added the ✋on hold status: on hold label Nov 16, 2023
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should we wait with merging until we prepare the release that includes the dip though?

@ntn-x2 ntn-x2 marked this pull request as draft November 30, 2023 10:13
@ntn-x2
Copy link
Member Author

ntn-x2 commented Nov 30, 2023

Yes, I put it on hold indeed. I also marked it as draft again to make it clearer.

* Add type definitions for the new dipSender runtime API

* Update types with new spec 11000

* Update type definitions

* Change keyIds input type
Rename producer -> provider and receiver -> consumer
Add dipProvider pallet for DID extrinsic signing
* Error types

* Update DIP provider runtime APIs types

* Update packages version
* Add version type

* Set package versions

* Fix identity commitment version type
@ntn-x2 ntn-x2 marked this pull request as ready for review December 13, 2023 14:21
@ntn-x2 ntn-x2 removed the ✋on hold status: on hold label Dec 13, 2023
@ntn-x2 ntn-x2 merged commit 62c68b5 into develop Dec 13, 2023
13 checks passed
@ntn-x2 ntn-x2 deleted the aa/dip branch December 13, 2023 15:12
ntn-x2 added a commit that referenced this pull request Dec 14, 2023
* Draft PR commit

* feat: DID merkle proofs (#744)

* Add type definitions for the new dipSender runtime API

* Update types with new spec 11000

* Update type definitions

* Change keyIds input type

* chore: support parties renaming (#751)

Rename producer -> provider and receiver -> consumer

* chore: update types for additional linked info (#759)

Update types

* feat: add `dipProvider` pallet for DID extrinsic signing (#764)

Add dipProvider pallet for DID extrinsic signing

* chore: set package version to 0.33.2-dip-0

* feat: error management (#802)

* Error types

* Update DIP provider runtime APIs types

* Update packages version

* feat: add versioning support (#806)

* Add version type

* Set package versions

* Fix identity commitment version type

* Update lock file

* Changes based on KILTprotocol/kilt-node@1e338a4

* Set version to DIP version

* Changes based on KILTprotocol/kilt-node@e23dbcc

* Update type definitions

* Revert package versions change

* Revert yarn.lock changes

* Set version to dip-2

* Revert package.json changes

* Add runtime calls to Peregrine runtimes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants