chore: DIP improvements #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weichweich @Ad96el PR is ready for review! As I mentioned above, I will open a few other ones for unit tests, benchmarks, and improved logging, at least. |
weichweich
reviewed
Feb 12, 2024
| LinkedDidInfoProviderError::DidNotFound => 0, | ||
| LinkedDidInfoProviderError::DidDeleted => 1, | ||
| LinkedDidInfoProviderError::TooManyLinkedAccounts => 2, | ||
| LinkedDidInfoProviderError::DidNotFound => 1, |
There was a problem hiding this comment.
Same here. A comment that and why 0 isn't allows would be good.
| @@ -0,0 +1,69 @@ | |||
| // KILT Blockchain – https://botlabs.org | |||
| // Copyright (C) 2019-2023 BOTLabs GmbH | |||
There was a problem hiding this comment.
if this code is copied from somewhere, do we need to include a copyright notice from the source?
There was a problem hiding this comment.
Do you think this is good now?
| @@ -0,0 +1,1299 @@ | |||
| // KILT Blockchain – https://botlabs.org | |||
There was a problem hiding this comment.
It might be worth splitting this file up.
There was a problem hiding this comment.
Yes, I wanted to do it in the testing PR, since it makes testing easier. I will probably leave this comment open and reference it in the ongoing testing PR.
There was a problem hiding this comment.
Will split this up as part of the unit test PR for that component, which is landing soon™!
Ad96el
reviewed
Feb 12, 2024
Ad96el
approved these changes
Feb 13, 2024
weichweich
approved these changes
Feb 13, 2024
ntn-x2
added a commit
that referenced
this pull request
Mar 28, 2024
Partially fixes KILTprotocol/ticket#2562. Adds unit tests for the verifier components (components tested are shown in the checklist below). It also splits up the proof verification logic into multiple files, split by when those checks are performed. Check the `crates/kilt-dip-primitives/src/merkle/v0/` folder for more details. It addresses an open comment in the DIP refactoring PR: #602 (comment). ## Elements to add tests for - [x] `pallet-dip-consumer` - [x] `pallet-relay-store` - [x] `ProofVerifier` - [x] Merge #612 - [x] Merge #613
Ad96el
pushed a commit
that referenced
this pull request
Apr 2, 2024
Fixes KILTprotocol/ticket#3054. It also contains a **breaking change** for cross-chain DID signature verifications. The signature now has a `valid_until` field, as discussed in #494 (comment). Besides that, other changes include: * A new set of types representing different stages of a cross-chain DIP proof, during the verification process. Everything starts with either a `RelayDipDidProof` or a `ParachainDipDidProof` and ends, if the whole verification flow succeeds, with a `DipVerifiedInfo`. * A generic `verify_storage_value_proof` that is used to verify a single storage element with a storage proof. * The `KiltVersionedParachainVerifier` now also depends on the relaychain runtime, which removes the need for some traits that provided just type definitions, such as `RelayChainStorageInfo` and `RelayChainStateInfo`. * Errors conversions into `u8` now start from `1` instead of `0`, for disambiguating between an error returning `u8::MAX` and another case returning `u8::MAX + 0`. * Refactoring of the different modules. **No unit tests or benchmarks yet, but this code should make it easier to do all of those**.
Ad96el
pushed a commit
that referenced
this pull request
Apr 2, 2024
Partially fixes KILTprotocol/ticket#2562. Adds unit tests for the verifier components (components tested are shown in the checklist below). It also splits up the proof verification logic into multiple files, split by when those checks are performed. Check the `crates/kilt-dip-primitives/src/merkle/v0/` folder for more details. It addresses an open comment in the DIP refactoring PR: #602 (comment). ## Elements to add tests for - [x] `pallet-dip-consumer` - [x] `pallet-relay-store` - [x] `ProofVerifier` - [x] Merge #612 - [x] Merge #613
ntn-x2
added a commit
that referenced
this pull request
Apr 4, 2024
Fixes KILTprotocol/ticket#3054. It also contains a **breaking change** for cross-chain DID signature verifications. The signature now has a `valid_until` field, as discussed in #494 (comment). Besides that, other changes include: * A new set of types representing different stages of a cross-chain DIP proof, during the verification process. Everything starts with either a `RelayDipDidProof` or a `ParachainDipDidProof` and ends, if the whole verification flow succeeds, with a `DipVerifiedInfo`. * A generic `verify_storage_value_proof` that is used to verify a single storage element with a storage proof. * The `KiltVersionedParachainVerifier` now also depends on the relaychain runtime, which removes the need for some traits that provided just type definitions, such as `RelayChainStorageInfo` and `RelayChainStateInfo`. * Errors conversions into `u8` now start from `1` instead of `0`, for disambiguating between an error returning `u8::MAX` and another case returning `u8::MAX + 0`. * Refactoring of the different modules. **No unit tests or benchmarks yet, but this code should make it easier to do all of those**.
ntn-x2
added a commit
that referenced
this pull request
Apr 4, 2024
Partially fixes KILTprotocol/ticket#2562. Adds unit tests for the verifier components (components tested are shown in the checklist below). It also splits up the proof verification logic into multiple files, split by when those checks are performed. Check the `crates/kilt-dip-primitives/src/merkle/v0/` folder for more details. It addresses an open comment in the DIP refactoring PR: #602 (comment). ## Elements to add tests for - [x] `pallet-dip-consumer` - [x] `pallet-relay-store` - [x] `ProofVerifier` - [x] Merge #612 - [x] Merge #613
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/KILTprotocol/ticket/issues/3054.
It also contains a breaking change for cross-chain DID signature verifications. The signature now has a
valid_untilfield, as discussed in #494 (comment).Besides that, other changes include:
RelayDipDidProofor aParachainDipDidProofand ends, if the whole verification flow succeeds, with aDipVerifiedInfo.verify_storage_value_proofthat is used to verify a single storage element with a storage proof.KiltVersionedParachainVerifiernow also depends on the relaychain runtime, which removes the need for some traits that provided just type definitions, such asRelayChainStorageInfoandRelayChainStateInfo.u8now start from1instead of0, for disambiguating between an error returningu8::MAXand another case returningu8::MAX + 0.No unit tests or benchmarks yet, but this code should make it easier to do all of those.