Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add multisig pallet to runtime #498

Merged
merged 11 commits into from
Apr 12, 2023
Merged

feat: add multisig pallet to runtime #498

merged 11 commits into from
Apr 12, 2023

Conversation

Ad96el
Copy link
Member

@Ad96el Ad96el commented Apr 4, 2023 •
edited
Loading

fixes KILTProtocol/ticket#312

The multisig pallet is added to the spiritnet and peregrine runtime.

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@Ad96el Ad96el requested review from ntn-x2 and weichweich April 4, 2023 12:40
ntn-x2
ntn-x2 reviewed Apr 4, 2023
View reviewed changes
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, but otherwise LGTM!

runtimes/common/src/constants.rs Show resolved Hide resolved
runtimes/peregrine/Cargo.toml Outdated Show resolved Hide resolved
runtimes/peregrine/src/lib.rs Show resolved Hide resolved
runtimes/spiritnet/Cargo.toml Outdated Show resolved Hide resolved
runtimes/spiritnet/src/lib.rs Show resolved Hide resolved
weichweich
weichweich reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@weichweich weichweich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some questions regarding the deposits.

runtimes/peregrine/src/lib.rs Outdated Show resolved Hide resolved
runtimes/common/src/constants.rs Outdated Show resolved Hide resolved
@Ad96el Ad96el merged commit 43869a2 into develop Apr 12, 2023
@Ad96el Ad96el deleted the feature/multisig branch April 12, 2023 08:56
ntn-x2 pushed a commit that referenced this pull request Apr 13, 2023
@Ad96el @ntn-x2
feat: add multisig pallet to runtime (#498)
cb071ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weichweich weichweich weichweich left review comments

@ntn-x2 ntn-x2 ntn-x2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ad96el @ntn-x2 @weichweich