-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to Polkadot v0.9.16 #319
Conversation
Scheduler: paritytech/substrate#10356 OriginPriviligeCmp: paritytech/polkadot#4166
/bench runtime spiritnet-runtime pallet_preimage |
Error running benchmark: wf-polkadot-0.9.16 stdoutFrom https://github.com/KILTprotocol/mashnet-node * branch develop -> FETCH_HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A super minor nitpick, but otherwise LGMT!
Since it has been running smoothly on the local setup, I will merge now and test on Spiritnet. |
fixes KILTProtocol/ticket#1793
pallets
directoryAllPallets
hook which executed pallets in the reverse order of their definition withinconstruct_runtime!
with the exception thatSystem
was always executed firstAllPalletsWithSystem
, we have to reorder some of our pallets, see 625df70 and 6363a5cstate_version
to runtime (Substrate #9732)#[pallet::without_storage_info]
, we skip generating storage info and can worry about this change later. It will be required for PoV benchmarksMaxEncodedLen
wherever necessaryToDo
AllPalletsReversedWithSystemFirst
which keeps the exact same order. Wondering why other teams switched toAllPalletsWithSystem
without any reordering.try-runtime
against Peregrine-stgtry-runtime
against SpiritnetChecklist:
array[3]
useget(3)
, ...)