Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to Polkadot v0.9.16 #319

Merged
merged 30 commits into from
Feb 9, 2022
Merged

feat: upgrade to Polkadot v0.9.16 #319

merged 30 commits into from
Feb 9, 2022

Conversation

wischli
Copy link
Contributor

@wischli wischli commented Jan 31, 2022

fixes KILTProtocol/ticket#1793

  • Upgrades to most recent Polkadot version v0.9.16
  • Removes crowdloan pallet from the pallets directory
  • Applies deprecation of AllPallets hook which executed pallets in the reverse order of their definition within construct_runtime! with the exception that System was always executed first
    • If we want to switch to the new default hook AllPalletsWithSystem, we have to reorder some of our pallets, see 625df70 and 6363a5c
  • Adds asset quota (Substrate #10382)
  • Adds state_version to runtime (Substrate #9732)
    • TODO in future PR: Switch to new trie format
  • Adds pallet_preimage + runs migration for Scheduler (Substrate #10356 + Polkadot #4166)
    • TODO in future PR: Set appropriate deposits for the Preimage deposit
  • Substrate switched to generate pallet storage info per default (Substrate #10662)
    • By using the macro#[pallet::without_storage_info], we skip generating storage info and can worry about this change later. It will be required for PoV benchmarks
    • TODO in future PR: Implement MaxEncodedLen wherever necessary

ToDo

  • Fix benchmarks / benchmark unit tests for DID
  • Fix benchmark / benchmark unit tests for DID Lookup
  • Fix unit tests for staking
  • Investigate order execution hook. If we want to be safe, we use AllPalletsReversedWithSystemFirst which keeps the exact same order. Wondering why other teams switched to AllPalletsWithSystem without any reordering.
  • Run pallet scheduler benchmarks
  • Run pallet preimage benchmarks
  • Execute try-runtime against Peregrine-stg
  • Execute try-runtime against Spiritnet

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@wischli wischli changed the base branch from develop to master February 1, 2022 17:08
@wischli wischli marked this pull request as ready for review February 1, 2022 17:38
@wischli
Copy link
Contributor Author

wischli commented Feb 2, 2022

/bench runtime spiritnet-runtime pallet_preimage

@kilt-command-bot
Copy link

kilt-command-bot bot commented Feb 2, 2022

Error running benchmark: wf-polkadot-0.9.16

stdoutFrom https://github.com/KILTprotocol/mashnet-node * branch develop -> FETCH_HEAD

@wischli wischli self-assigned this Feb 2, 2022
@wischli wischli added the ❤️ high priority: high label Feb 2, 2022
Copy link
Contributor

@weichweich weichweich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A super minor nitpick, but otherwise LGMT!

pallets/did/src/mock_utils.rs Outdated Show resolved Hide resolved
@wischli
Copy link
Contributor Author

wischli commented Feb 9, 2022

Since it has been running smoothly on the local setup, I will merge now and test on Spiritnet.

@wischli wischli merged commit 365c716 into master Feb 9, 2022
@wischli wischli deleted the wf-polkadot-0.9.16 branch February 9, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❤️ high priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants