feat!: getExtensions isn't a promise #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weichweich
force-pushed
the
aw-rework-get-extension
branch
from
935f46e
to
1aa1d74
Compare
arty-name
reviewed
May 3, 2023
src/getExtension/getExtension.ts
Outdated
Comment on lines
19
to
21
| // copy all extensions into a new object since the caller should be allowed to change the object | ||
| // without changing the underlying extension object. | ||
| return { ...apiWindow.kilt } |
There was a problem hiding this comment.
I am surprised to see this requirement. This will also likely lose the very special versions property. I’d rather simply return the kilt object.
src/getExtension/getExtension.ts
Outdated
| * If an extension injects itself only after this function is called, it will not be contained in the returned extensions. | ||
| * @returns an object containing extensions | ||
| */ | ||
| export function getExtensions(): Record<string, InjectedWindowProvider<PubSubSessionV1 | PubSubSessionV2>> { |
There was a problem hiding this comment.
Can we get a type that includes all the PubSubSessions? That would also be interesting to export as well.
There was a problem hiding this comment.
You are referring to all started sessions with the extensions?
it's expected to get a list of extensions
arty-name
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related https://github.com/KILTprotocol/ticket/issues/2126
This PR changes the
getExtensionfunction.window.kiltproperty)Future additions
we already dispatch the
kilt-dapp#initializedeven though it's not part of the Credential API 3.0.Once the events are part of the credential API we should include a function for listening to new extensions.