Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

617 bulk widget creation #619

Merged
merged 7 commits into from
Dec 3, 2019
Merged

617 bulk widget creation #619

merged 7 commits into from
Dec 3, 2019

Conversation

JelleBoersma
Copy link
Contributor

The code works, but there is a coverage upload error in the automated tests that I don't understand...

@JelleBoersma JelleBoersma requested a review from jberends December 3, 2019 10:18
@JelleBoersma JelleBoersma self-assigned this Dec 3, 2019
Copy link
Member

@jberends jberends left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also had to run pydocstyle as it failed. please run tox dist_and_docs locally. Create a run command in pycharm for it.

@jberends
Copy link
Member

jberends commented Dec 3, 2019

The code works, but there is a coverage upload error in the automated tests that I don't understand...

It seems that tonight, a new release of coveralls fixes this problem. Although the release was during the moment that I wrote an issue report on the coveralls github tracker.

@jberends jberends merged commit 3c0d380 into master Dec 3, 2019
@jberends jberends deleted the 617_bulk_widget_creation branch December 3, 2019 21:33
jberends pushed a commit that referenced this pull request Nov 9, 2021
* #617 cherry-pick from prototype branch `async_widgets`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants