-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KDT0_JungHyoJu 카카오 클론 코딩 (기존 pr closed 후 ) #73
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for kdt0-junghyoju-kakaoclone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
<!-- 링크 설정 --> | ||
<link rel="stylesheet" href="main.css"> | ||
<script src="./main.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
알고계시겠지만 script 태그를 head 태그 하단에 넣으시려면 defer 속성을 추가하시는 게 좋아보여요! 아니면 body 태그 하단에 defer 속성 없이 넣으셔도 괜찮을 것 같아요. head 태그 하단에 그냥 script를 넣어버리면 화면 로딩이 오래 걸릴 수 있어요! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
참고자료까지 피드백 너무 감사합니다 !! 😀
작업하신 사이트 잘 보았습니다!
|
background: url('./images/visual_subscribe_icon.png') no-repeat; | ||
width: 60px; | ||
height: 60px; | ||
background-position: 0 60 ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
background-position: 0px 0px;
위치의 경우 px이나 %등 단위를 붙여주어야 작동하는것같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
background-size: 317px로 하니까 카카오사이트랑 비슷한것같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해결방안까지 피드백 감사드립니다 !! 말씀해주신대로 수정하여 보완해보도록 하겠습니당 👍
<div class="left__sticky"> | ||
|
||
<!-- 보도 자료 --> | ||
<div class="left_box"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요.
카드에 CSS적용하실 때, hover와 같이 기존값에 변경이 되었다면 card에 transition: all 1s와 같이 해주시면 효과가 부드러워질 것 입니다.
- | ||
* html, css만을 사용하여 구현 | ||
* 뉴스 카드 wrap을 이용하여 배치 후 overflow 구현 후 스크롤 숨김 | ||
* 디테일 링크 설정 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
실제 디테일 링크랑 자연스럽게 잘 엮어서 탐색해보는 사람이 더 자연스럽게 느낄 수 있었던 거 같습니다! 잘 봤습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 추가로 헤더 메뉴 부분에 글씨가 밑으로 짤려서 내려가는 이슈가 있어서 이 부분 수정하면 좋을 거 같습니다!
.visual .info-main .main__container .container__item__left .left_box:hover{ | ||
transform : matrix(1, 0, 0, 1, 0, -5) ; | ||
box-shadow: 10px 10px 5px rgba(0, 0, 0, 0.3); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
js 없이 구현했다는 게 너무 인상 깊었습니다! js없이 번거로웠을 것 같은데 js를 대신해서 사용한 효과가 있을까요?
KaKao 웹페이지 클론코딩
링크 : https://kdt0-junghyoju-kakaoclone.netlify.app/
원본 페이지
링크 : https://www.kakaocorp.com/page/
사용기술
1.css
2.html
구현 사항
아쉬운 점
느낀 점