Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options generated as numbers rather than enum values #177

Open
jesperkdab opened this issue Oct 4, 2024 · 0 comments · May be fixed by #224
Open

Options generated as numbers rather than enum values #177

jesperkdab opened this issue Oct 4, 2024 · 0 comments · May be fixed by #224
Assignees
@narnaud
Milestone
Release 1.0.0

Comments

@jesperkdab
Copy link

record a script where you search for a regular expression, and the generated script looks like this:
document.find("#include <([^/])/(.*)>", 8)

The key thing is 8, which should be generated as the enum TextDocument.FindRegexp instead
@narnaud narnaud self-assigned this Nov 20, 2024
@narnaud narnaud added this to the Release 1.0.0 milestone Nov 20, 2024
narnaud added a commit to narnaud/knut that referenced this issue Nov 20, 2024
@narnaud
feat: Use enum values rather than int for recording
42114e0 
This makes it easier for a human to read and edit the script after the fact.
Mostly useful for the find API in TextDocument

Fix KDAB#177
@narnaud narnaud linked a pull request Nov 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@narnaud narnaud

Labels
None yet
Projects
None yet
Milestone
Release 1.0.0
Development

Successfully merging a pull request may close this issue.

feat: Use enum values rather than int for recording narnaud/knut
2 participants
@narnaud @jesperkdab