WIP: Add QLocale #1086
WIP: Add QLocale #1086
Conversation
| #[rust_name = "first_day_of_week"] | ||
| fn firstDayOfWeek(self: &QLocale) -> DayOfWeek; | ||
|
|
||
| // QString QLocale::formattedDataSize(qint64 bytes, int precision = 2, QLocale::DataSizeFormats format = DataSizeIecFormat) const |
There was a problem hiding this comment.
DataSizeFormats is QFlags, do we have prior art on how to model that?
There was a problem hiding this comment.
We unfortunately don't have anything for flags yet i don't think, we support enums but not flags.
@LeonMatthesKDAB something to figure out for 0.8 ?
There was a problem hiding this comment.
Right, sounds useful to find an ergonomic way to use Flags for 0.8. We don't have anything yet though.
nicolasfella
force-pushed
the
work/nico/qlocale
branch
2 times, most recently
from
7a3503e
to
66a08f2
Compare
|
Added a test |
nicolasfella
force-pushed
the
work/nico/qlocale
branch
3 times, most recently
from
05c8552
to
018040e
Compare
nicolasfella
force-pushed
the
work/nico/qlocale
branch
2 times, most recently
from
a9b5564
to
a18034f
Compare
nicolasfella
force-pushed
the
work/nico/qlocale
branch
2 times, most recently
from
8ceb564
to
737b966
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1086 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 11927 11927
=========================================
Hits 11927 11927 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
nicolasfella
force-pushed
the
work/nico/qlocale
branch
from
737b966
to
138c0f8
Compare
nicolasfella
force-pushed
the
work/nico/qlocale
branch
4 times, most recently
from
24c2177
to
aa291a5
Compare
| @@ -46,7 +46,7 @@ set(CRATE qt_types_standalone) | |||
| cxx_qt_import_crate( | |||
| MANIFEST_PATH rust/Cargo.toml | |||
| CRATES ${CRATE} | |||
| QT_MODULES Qt::Core Qt::Gui Qt::Qml | |||
| QT_MODULES Qt::Core Qt::Gui Qt::Widgets Qt::Qml | |||
There was a problem hiding this comment.
Could try adding QuickControls2 here which might help with the order, as qt_quickcontrols is enabled in cxx-qt-lib. But this ordering issue is still painful when it happens :-/
nicolasfella
force-pushed
the
work/nico/qlocale
branch
from
d42d379
to
a5669e7
Compare
Not complete yet because: