WIP: Add QLocale #1086
WIP: Add QLocale #1086
Conversation
| #[rust_name = "first_day_of_week"] | ||
| fn firstDayOfWeek(self: &QLocale) -> DayOfWeek; | ||
|
|
||
| // QString QLocale::formattedDataSize(qint64 bytes, int precision = 2, QLocale::DataSizeFormats format = DataSizeIecFormat) const |
There was a problem hiding this comment.
DataSizeFormats is QFlags, do we have prior art on how to model that?
There was a problem hiding this comment.
We unfortunately don't have anything for flags yet i don't think, we support enums but not flags.
@LeonMatthesKDAB something to figure out for 0.8 ?
There was a problem hiding this comment.
Right, sounds useful to find an ergonomic way to use Flags for 0.8. We don't have anything yet though.
nicolasfella
force-pushed
the
work/nico/qlocale
branch
2 times, most recently
from
7a3503e
to
66a08f2
Compare
|
Added a test |
nicolasfella
force-pushed
the
work/nico/qlocale
branch
3 times, most recently
from
05c8552
to
018040e
Compare
| _cspec: MaybeUninit<usize>, | ||
| } | ||
|
|
||
| impl Default for QLocale { |
There was a problem hiding this comment.
As QLocale is not trivially copyable or destructible can you add a impl Clone for QLocale and a impl Drop for QLocale implementation similar to other places (note we have templates for those too eg see how QString is done)
| } | ||
| } | ||
|
|
||
| fn construct_qlocale() -> QLocale { |
There was a problem hiding this comment.
once you have Clone implemented you could add a clone test
nicolasfella
force-pushed
the
work/nico/qlocale
branch
from
018040e
to
a9b5564
Compare
nicolasfella
force-pushed
the
work/nico/qlocale
branch
from
a9b5564
to
a18034f
Compare
Not complete yet because: