Skip to content

Commit

Permalink
Don't fail fast
Browse files Browse the repository at this point in the history
It's a nightly, better use the time to check the whole thing on all
configurations.

Unfortunately, with "continue-on-error: true" GitHub actions will still
mark the workflow run as successful even if all the steps fail. However,
we'd like to run Cppcheck even if clang-tidy gets errors.

Not possible, it's a limitation of GitHub actions documented in:
 - actions/runner#2347
 - https://github.com/orgs/community/discussions/15452

GitHub folks collected feedback for this over a year ago:
https://github.com/orgs/community/discussions/15452#discussioncomment-5184613

but it's still not fixed.
  • Loading branch information
MiKom committed Jul 12, 2024
1 parent 2550fec commit ac06e21
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
- name: Windows
os: windows-2022
tidy-executble: clang-tidy
fail-fast: false
continue-on-error: true

steps:
Expand Down

0 comments on commit ac06e21

Please sign in to comment.