compiled error when wsdl code generated #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfaure-kdab
requested changes
Mar 18, 2019
| @@ -91,3 +91,6 @@ add_subdirectory(onvif_org_event) | |||
| add_subdirectory(empty_list_wsdl) | |||
| add_subdirectory(list_restriction) | |||
|
|
|||
| add_subdirectory(kddatetime) | |||
There was a problem hiding this comment.
Please rebase on top of master, this is already in there.
| @@ -0,0 +1,20 @@ | |||
| #include "wsdl_test_qsharedpointer_include_wsdl.h" | |||
|
|
|||
| #include <QtTest> | |||
There was a problem hiding this comment.
That's the full module including all of QtCore, please include only QTest.
|
|
||
| #include <QtTest> | ||
|
|
||
| class rightInclude: |
There was a problem hiding this comment.
class capitalization: RightInclude
|
|
||
| void testCompiled() | ||
| { | ||
| QVERIFY(true); |
There was a problem hiding this comment.
This statement does nothing, please remove it.
You could at least create an instance of the service, so that this doesn't compile with a fully empty generated file ;)
Hello_Service service;
unittests/unittests.pro
Outdated
| @@ -37,6 +37,7 @@ SUBDIRS = \ | |||
| encapsecurity \ | |||
| prefix_wsdl \ | |||
| vidyo \ | |||
| kddatetime \ | |||
postrstk
force-pushed
the
compile-error-without-qsharedpointer-include
branch
from
51dac4a
to
c8ea933
Compare
postrstk
force-pushed
the
compile-error-without-qsharedpointer-include
branch
from
c8ea933
to
01cc592
Compare
|
changed adding a |
|
As I see, all issues are resolved. Do you have additional questions? |
winterz
pushed a commit
that referenced
this pull request
May 13, 2019
…ted code (#170) * add test with compiled error code generated * fix class name * include only QTest * include QSharedPointer in header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error is that when generating code, the inclusion of
<QSharedPointer>occurs incode_from_wsdl.cpp, and not incode_from_wsdl.h