runtime: cleanup strict_authority_validation (envoyproxy#12119)

Fixes envoyproxy#11934 Signed-off-by: Matt Klein <[email protected]> Signed-off-by: Kevin Baichoo <[email protected]>
KBaichoo · Jul 30, 2020 · 68f010d · 68f010d
1 parent f788c62
commit 68f010d
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/docs/root/version_history/current.rst b/docs/root/version_history/current.rst
@@ -28,6 +28,7 @@ Removed Config or Runtime
 
 * http: removed legacy header sanitization and the runtime guard `envoy.reloadable_features.strict_header_validation`.
 * http: removed legacy transfer-encoding enforcement and runtime guard `envoy.reloadable_features.reject_unsupported_transfer_encodings`.
+* http: removed configurable strict host validation and runtime guard `envoy.reloadable_features.strict_authority_validation`.
 
 New Features
 ------------

diff --git a/source/common/http/header_utility.cc b/source/common/http/header_utility.cc
@@ -223,8 +223,7 @@ void HeaderUtility::stripPortFromHost(RequestHeaderMap& headers, uint32_t listen
 absl::optional<std::reference_wrapper<const absl::string_view>>
 HeaderUtility::requestHeadersValid(const RequestHeaderMap& headers) {
   // Make sure the host is valid.
-  if (Runtime::runtimeFeatureEnabled("envoy.reloadable_features.strict_authority_validation") &&
-      headers.Host() && !HeaderUtility::authorityIsValid(headers.Host()->value().getStringView())) {
+  if (headers.Host() && !HeaderUtility::authorityIsValid(headers.Host()->value().getStringView())) {
     return SharedResponseCodeDetails::get().InvalidAuthority;
   }
   return absl::nullopt;

diff --git a/source/common/runtime/runtime_features.cc b/source/common/runtime/runtime_features.cc
@@ -56,7 +56,6 @@ constexpr const char* runtime_features[] = {
     "envoy.reloadable_features.http1_flood_protection",
     "envoy.reloadable_features.test_feature_true",
     "envoy.reloadable_features.connection_header_sanitization",
-    "envoy.reloadable_features.strict_authority_validation",
     // Begin alphabetically sorted section.
     "envoy.reloadable_features.activate_fds_next_event_loop",
     "envoy.deprecated_features.allow_deprecated_extension_names",