CI: Add tests for documented dependency installation #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broken due to KATRIN-Experiment#87
We state Kassiopeia would be compatible starting with ROOT version 6.16, so we should also test against an older version of ROOT. This is the newest patch of the oldest version of ROOT that is available for Ubuntu 20.04.
Due to the use of `TGraph::AddPoint` in `KSROOTZonalHarmonicsPainter`, it is no longer possible to use ROOT versions older than 6.23.2. Since the last published 6.23 version with binaries is 6.23.1, ROOT is just supported beginning with version 6.24.
|
Thanks a lot for this! Looks very nice. I see from your fork that the tests ran smoothly on your end, so I would go ahead and merge this today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds tests that follow the installation procedure described in https://katrin-experiment.github.io/Kassiopeia/compiling.html to test if the recommended dependency installation actually works. Consequently, the documentation is updated for Ubuntu 20.04 and Fedora 37.