-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ophthalmology - Add manual blinking and eye injuries #296
base: dev-Tomcat
Are you sure you want to change the base?
Conversation
The stringtable is pretty fucked atm, some adjustments are needed there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably missed smth, i am not good with PP Effects so i can't really review this without access to Arma.
I think few things would need to be discussed further.
addons/ophthalmology/functions/fnc_treatmentAdvanced_eyewash.sqf
Outdated
Show resolved
Hide resolved
["KAT_EyewasherItem", "KAT_Eyewasher"] call ACEFUNC(common,registerItemReplacement); | ||
|
||
["CBA_settingsInitialized", { | ||
if (!GVAR(enable) && !GVAR(enableManualBlinking)) exitWith {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but wouldnt that mean that if someone enable this addon, but dont want manual blinking, there wont be dust injury effect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it would not
params ["_unit","_dead"]; | ||
TRACE_2("handleRespawn",_unit,_dead); | ||
|
||
[_unit] call FUNC(fullHealLocal); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why calling fullHealLocal on respawn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because fullHealLocal stores all default variables, this way its easier to keep track of it
When merged, this pull request will: