Support <tippy> as a child #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The was used twice and we need this code only once, simlifying the actual rendering returns.
Having <Tippy> as a child of an element to tooltip was a nice use-case in 4.x. See KABBOUCHI#123. We re-add this in a similar manner. Using to="parent" (as a fixed string), one can now use either the main <Tippy> slot ("default") or its specific "content" slot to specify the tooltip content. The tooltip will be triggered on the parent element without adding a specifc Tippy node to the DOM. This should provides a non-interfering way to specify tooltips. Implementation: For the to="parent" case, we need to find the parent DOM element, but in the "worst" case <Tippy> won't render any DOM nodes at all, which could help us to find the parent. Instead, we initially render a hidden <span> (and the tooltip content). Using the span as a template ref ('findParentHelper'), we can get the parent and assign that to the actual 'elem' ref. This will trigger a re-render, where we can drop the helper <span> again.
✅ Live Preview ready!
|
|
Nice I like it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the "tippy component as a child" behavior from the 4.x version back.
It is slightly different from the old functionality, because this now requires the
to='parent'prop to be set on the Tippy compoent.This should make it easier to understand, where this tooltip belongs and also simplifies the implementation.
I like this "Tippy as a child" style, because in my mind a tooltip is just a small aspect of a component. "Hiding" it as a child seems nicer to me than having Tippy be the parent of the tooltipped element.
This also behaves like
:tag="null", i.e. not adding new DOM nodes under or around the tooltipped element. This helps with adding a tooltip without breaking existing styles.There is some more technical details in the commit messages.
This change allows the following new ways of using Tippy:
or
or