Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies and start migrating members #355

Merged
merged 22 commits into from
Apr 8, 2019
Merged

Conversation

Embraser01
Copy link
Member

@Embraser01 Embraser01 commented Feb 19, 2019

Goal of this PR

Redesign the members pages.
Now, there is 3 components:

  • ListComponent ==> Containing a fully featured list with server-side search and pagination
  • NewComponent ==> A Dialog modal (with routing) to quickly create a new member
  • EditComponent ==> Another Dialog modal (with routing) to edit a member (but not its registrations for now)

Also, for registration, it will be simple:

  • Search the member in the list
  • If found, click the registration button
    • A dialog (not routed) appear
    • Change school if needed
    • Validate, and that's all
  • If not found click on create...

Remaining work to do

  • Create system for custom flags
  • Add migration script (WIP)
  • Create a future task to delete members (once everything is working)
  • Handle VA Members (see for a bridge)
  • Transform to uppercase school

To handle cases where there is problems with registration (missing card)

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #355 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #355   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files          83     83           
  Lines        1910   1942   +32     
  Branches      192    200    +8     
=====================================
- Misses       1718   1742   +24     
- Partials      192    200    +8
Impacted Files Coverage Δ
...vices/inventory-management/stock-events.service.js 0% <ø> (ø) ⬆️
.../services/inventory-management/products.service.js 0% <ø> (ø) ⬆️
...services/inventory-management/providers.service.js 0% <ø> (ø) ⬆️
...p/services/inventory-management/shelves.service.js 0% <ø> (ø) ⬆️
server/utils/index.js 0% <ø> (ø) ⬆️
server/moleculer-app/services/api.service.js 0% <0%> (ø) ⬆️
...ver/moleculer-app/services/core/members.service.js 0% <0%> (ø) ⬆️
server/utils/helpers.js 0% <0%> (ø) ⬆️
...erver/moleculer-app/mixins/joi-db-actions.mixin.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c737c3f...14e4b0a. Read the comment docs.

@Embraser01 Embraser01 marked this pull request as ready for review March 16, 2019 23:42
@Embraser01 Embraser01 merged commit b659fef into master Apr 8, 2019
@Embraser01 Embraser01 deleted the migrate-members branch April 8, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant