Expose JavaScript peripheral advertisments #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twyatt
reviewed
Apr 29, 2021
Comment on lines
+68
to
+70
| runCatching { | ||
| offer(Advertisement(it as BluetoothAdvertisingEvent)) | ||
| }.onFailure { |
There was a problem hiding this comment.
Rather than use runCatching, we should bump the Coroutines version and use trySend.
There was a problem hiding this comment.
A quick scan shows five other instances of runCatching in this repo - perhaps the use of this pattern should be reviewed more broadly as a separate issue?
There was a problem hiding this comment.
Ya, I am going to update the other usages soon. 👍
sdonn3
approved these changes
Apr 29, 2021
|
Closing this PR as decided against exposing this asymmetric portion of API and deferring for now, perhaps until the Web Bluetooth scanning interface is ratified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose an
advertisementsproperty onJsPeripheralvia the Web BLEwatchAdvertisementsmethod.The code to do this was already there in order to provide the
rssi()functionality. This change provides general access to the peripheral advertisements, and re-implementsrssi()using the new property.There are use cases where certain information is vended solely via the advertisements, so it can be necessary to obtain the advertisements from a connected peripheral in the case where the scanner was not used initially.