Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InnerProductSpace
andEuclideanSpace
as abstract types.InnerProductStyle
as a trait based mechanism to query if a space has an inner product.NoInnerProduct
,HasInnerProduct
andEuclideanInnerProduct
as traitsRemark:
It might be clearer to remove this distinction altogether. I don't know of a current use of
GeneralSpace
, which is the only non-Euclidean spacetype to begin with. If we are happy with this design I'll update the docs as well