Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for empty blocks in left/right-orth #49

Merged
merged 1 commit into from
Jan 31, 2021
Merged

allow for empty blocks in left/right-orth #49

merged 1 commit into from
Jan 31, 2021

Conversation

maartenvd
Copy link
Contributor

@maartenvd maartenvd commented Jan 16, 2021

at the moment, the following is inconsistent:

    t = TensorMap(zeros,ComplexF64,Rep[SU₂](1=>10)*Rep[SU₂](1=>2),Rep[SU₂](1=>10));
    #(l,q) = rightorth(t,alg=LQpos()); #fails

    data = convert(Array,t);
    tt = TensorMap(data,ℂ^size(data,1)*ℂ^size(data,2),ℂ^size(data,3))
    (l,q) = rightorth(tt,alg=LQpos()); #works

In this pull request they now work the same way - by making l rank-defficient, while q remains unitary.

@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #49 (be3dd61) into master (846a68e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   74.96%   74.98%   +0.01%     
==========================================
  Files          32       32              
  Lines        3907     3909       +2     
==========================================
+ Hits         2929     2931       +2     
  Misses        978      978              
Impacted Files Coverage Δ
src/tensors/factorizations.jl 95.54% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 846a68e...be3dd61. Read the comment docs.

@Jutho
Copy link
Owner

Jutho commented Jan 31, 2021

Look's good; thanks.

@Jutho Jutho merged commit 7ad956b into Jutho:master Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants