Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export isstrided #31

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Export isstrided #31

merged 1 commit into from
Oct 7, 2024

Conversation

lkdvos
Copy link
Contributor

@lkdvos lkdvos commented Oct 7, 2024

Closes #30

@Jutho
Copy link
Owner

Jutho commented Oct 7, 2024

Is this not exported in StridedViews?

@lkdvos
Copy link
Contributor Author

lkdvos commented Oct 7, 2024

It is, but it does not get pushed through.
I guess the question is more something along the lines of:
Should an end-user, that requires Strided.jl, also import StridedViews.jl?
Right now, all exports from StridedViews (except for isstrided) are just re-exported, and it is quite convenient to not have to import both. Additionally, I do feel like isstrided could be part of the public interface.

@Jutho Jutho merged commit 39bc28c into Jutho:main Oct 7, 2024
11 checks passed
@lkdvos lkdvos deleted the ld-isstrided branch October 7, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-export StridedViews.isstrided
2 participants
@lkdvos @Jutho