Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove engine requirement from package.json #267

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Aarbel
Copy link

@Aarbel Aarbel commented Sep 6, 2024

@JustinBeckwith

i fixed this, because this package is used by other libraries that still need to run on older node versions.

Imposing node >=18 on an utilitary library like this one is maybe not an "open source community" good practice

cf https://github.com/JustinBeckwith/retry-axios/blob/main/package.json, here are examples of the package.json files of the dependencies used by retry-axios:

  "peerDependencies": {
    "axios": "*"
  },
  "devDependencies": {
    "@biomejs/biome": "^1.8.3",
    "@types/mocha": "^10.0.1",
    "@types/node": "^20.0.0",
    "@types/sinon": "^17.0.0",
    "axios": "^1.2.1",
    "c8": "^10.0.0",
    "js-green-licenses": "^4.0.0",
    "mocha": "^10.2.0",
    "nock": "^13.3.0",
    "semantic-release": "^24.0.0",
    "sinon": "^18.0.0",
    "typescript": "~5.5.0"
  },

@Aarbel Aarbel changed the title Update package.json and node minimum version Remove engine requirement from package.json Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant