Adds handling for browsers where WebGL is disabled or unavailable #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a tricky one. Apparently there is little or no accounting for this - I looked through react-mapbox-gl and tried some of the event handlers (
onWebGlContextLost
,onError
?) but they didn't seem to affect anything.So in the meantime I threw in some code that detects if the browser has WebGL or not (see
MapHelpers
), and throws up a terrible error message and doesn't allow the user to use the map at all:How to reproduce
You can disable WebGL/hardware acceleration on Chrome in Settings > Advanced Settings > Use hardware acceleration when available:
@toolness @sraby interested to hear your thoughts! Specifically it would be good to know if we can find a way to degrade this in a better fashion so a version of the map could still maybe be displayed...