Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #438.
Notes
We work around Unexpected error when using generic with Pick and Exclude microsoft/TypeScript#28748 by using the fix described in Unexpected error when using generic with Pick and Exclude microsoft/TypeScript#28748 (comment). At first I got the heebie-jeebies when I saw
props as any
but as the OP says, we keep all the type checking on the outside, so type safety is maintained where it matters most. I've also left a note about this fix in all the places it's applied so that hopefully we can remove the workaround at some point when the issue is fixed.TypeScript 3.2's new support for
Function.prototype.apply
meant tweaking some typings where we used it.Apparently we were using the wrong
behavior
value for aScrollBehavior
but we should manually make sure nothing's broken.To do