Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix monitoring integration with actual prometheus #3183

Merged
merged 10 commits into from
Apr 7, 2024
Merged

Fix monitoring integration with actual prometheus #3183

merged 10 commits into from
Apr 7, 2024

Conversation

Abrynos
Copy link
Member

@Abrynos Abrynos commented Apr 5, 2024 •
edited
Loading

Checklist

  • I read and understood the Contributing Guidelines.
  • This is not a duplicate of an existing merge request.
  • I believe this falls into the scope of the project and should be part of the built-in functionality.
  • My code follows the code style of this project.
  • I have added tests to cover my changes, wherever they are necessary.
  • All new and existing tests pass.

Changes

Downgrades OpenTelemetry.Exporter.Prometheus.AspNetCore from 1.8.0-rc.1 to 1.7.0-rc.1 due to issues in providing valid metrics via its endpoint. Also disables automatic upgrades by renovate bot.

Additionally the one metric where it makes sense now has a unit added and some of the other packages are upgraded (so renovate bot has less work).

Additional info

I've already verified this to work with generic ASF 6.0.2.0.

After I have official binaries I'll let it run for a few days and create a dashboard and screenshots. Dashboard we can potentially integrate in the repository itself. Screenshots might be useful for the first draft of wiki page (you already got that from me).

Thank you for considering the inclusion of this merge request.

JustArchi
JustArchi requested changes Apr 6, 2024
View reviewed changes
.github/renovate.json5 Outdated Show resolved Hide resolved
@JustArchi JustArchi added 🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. labels Apr 6, 2024
@Abrynos
Add build and runtime information metrics
184323c 
It is not recommended to include this information as labels in all
metrics. Instead, we add two special metrics with a constant value of
"1" and restrict those static pieces of information to them
@JustArchi JustArchi added 🔧 Fixes required Issues marked with this label require further follow-up fixes before they can be considered. 🚧 Work in progress Issues marked with this label are in active work-in-progress and they're not ready for review yet. labels Apr 7, 2024
@Abrynos Abrynos mentioned this pull request Apr 7, 2024
Closed
@JustArchi JustArchi merged commit 9016a51 into JustArchiNET:main Apr 7, 2024
21 checks passed
@JustArchi
Copy link
Member

Thanks! 🏆

@Abrynos Abrynos deleted the monitoring branch April 8, 2024 05:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JustArchi JustArchi JustArchi approved these changes

Assignees
No one assigned
Labels
🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🔧 Fixes required Issues marked with this label require further follow-up fixes before they can be considered. 🚧 Work in progress Issues marked with this label are in active work-in-progress and they're not ready for review yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abrynos @JustArchi