Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement plugin updates with IPluginUpdates interface #3151

Merged
merged 33 commits into from
Mar 16, 2024
Merged

Implement plugin updates with IPluginUpdates interface #3151

merged 33 commits into from
Mar 16, 2024

Conversation

JustArchi
Copy link
Member

@JustArchi JustArchi commented Mar 9, 2024 •
edited
Loading

Code is done, but untested, I'll make this PR ready for review when I ensure it works as expected.

TODO:

  • Testing
  • More strings
  • Localization
  • Change plugin template to follow root-less zip structure
  • Make plugin template implement new interface

@JustArchi JustArchi added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🚧 Work in progress Issues marked with this label are in active work-in-progress and they're not ready for review yet. labels Mar 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024 •
edited
Loading

Qodana for .NET

7 new problems were found

Inspection name Severity Problems
RoslynAnalyzers Do not catch general exception types ◽️ Notice 6
RoslynAnalyzers Enum Storage should be Int32 ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@JustArchi JustArchi added 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. 🏁 Finished Issues marked with this label were finished already and no further work is required on them. and removed 🚧 Work in progress Issues marked with this label are in active work-in-progress and they're not ready for review yet. labels Mar 12, 2024
Abrynos
Abrynos reviewed Mar 12, 2024
View reviewed changes
ArchiSteamFarm/Core/Utilities.cs Outdated Show resolved Hide resolved
ArchiSteamFarm/Plugins/Interfaces/IGitHubPluginUpdates.cs Show resolved Hide resolved
ArchiSteamFarm/Plugins/PluginsCore.cs Outdated Show resolved Hide resolved
@Abrynos
Copy link
Member

Abrynos commented Mar 14, 2024

I like where this is going.

@JustArchi JustArchi requested review from Abrynos and Rudokhvist March 14, 2024 11:11
Abrynos
Abrynos suggested changes Mar 14, 2024
View reviewed changes
ArchiSteamFarm/Core/Utilities.cs Outdated Show resolved Hide resolved
@JustArchi JustArchi requested a review from Abrynos March 15, 2024 12:42
@JustArchi JustArchi merged commit aedede3 into main Mar 16, 2024
44 checks passed
@JustArchi JustArchi deleted the feature/plugin-updates branch March 16, 2024 22:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ezhevita ezhevita ezhevita approved these changes

@Abrynos Abrynos Abrynos approved these changes

@Rudokhvist Rudokhvist Awaiting requested review from Rudokhvist

Assignees
No one assigned
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. 🏁 Finished Issues marked with this label were finished already and no further work is required on them.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JustArchi @Abrynos @ezhevita