Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GlobalConfig update via IPC removing IPCPassword #2379

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Fix GlobalConfig update via IPC removing IPCPassword #2379

merged 1 commit into from
Jul 23, 2021

Conversation

Abrynos
Copy link
Member

@Abrynos Abrynos commented Jul 23, 2021

Currently updating GlobalConfig via the respective IPC endpoint resets IPCPassword to its default value. This merge request attempts to fix the issue.

@Abrynos Abrynos mentioned this pull request Jul 23, 2021
Closed
@Abrynos
Copy link
Member Author

Abrynos commented Jul 23, 2021

Since this is quite a problematic issue, I think it would be wise to put out a security alert as well.

Rudokhvist
Rudokhvist approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@Rudokhvist Rudokhvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ezhevita
Copy link
Member

I knew #2371 wasn't useless 😅

@JustArchi JustArchi added the 🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. label Jul 23, 2021
@JustArchi JustArchi merged commit 4b7edf3 into JustArchiNET:main Jul 23, 2021
@Abrynos Abrynos deleted the fix-clear-ipcpassword branch July 23, 2021 14:54
@JustArchi
Copy link
Member

Thanks! 🏆

I'll make a security alert and speed-up the release of ASF with a fix once I confirm it works properly.

@Abrynos Abrynos added the 🏁 Finished Issues marked with this label were finished already and no further work is required on them. label Aug 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ezhevita ezhevita ezhevita approved these changes

@Rudokhvist Rudokhvist Rudokhvist approved these changes

@JustArchi JustArchi JustArchi approved these changes

Assignees
No one assigned
Labels
🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. 🏁 Finished Issues marked with this label were finished already and no further work is required on them.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Abrynos @ezhevita @JustArchi @Rudokhvist