Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ArchiHandler to fetch owned games #2370

Merged
merged 2 commits into from
Jul 10, 2021
Merged

Use ArchiHandler to fetch owned games #2370

merged 2 commits into from
Jul 10, 2021

Conversation

ezhevita
Copy link
Member

This method doesn't require a valid API key and contains all the apps which ArchiWebHandler.GetOwnedGames provides. SteamKit update is required due to skip_unvetted_apps parameter missing in versions prior to 2.4.0-Alpha.2.

JustArchi
JustArchi approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@JustArchi JustArchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this PR a lot 🙂

@JustArchi JustArchi added the ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. label Jul 10, 2021
@JustArchi JustArchi merged commit fd4c1ef into JustArchiNET:main Jul 10, 2021
@JustArchi
Copy link
Member

Thanks a lot for that, it's rare that we can only improve something so nicely without having to sacrifice something in return 🏆

@ezhevita ezhevita deleted the fetch-owned-archihandler branch July 10, 2021 15:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Abrynos Abrynos Abrynos requested changes

@JustArchi JustArchi JustArchi approved these changes

Assignees
No one assigned
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezhevita @JustArchi @Abrynos