-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: ShouldAcceptTrade() System.TimeoutException: Failed due to error: DuplicateRequest #3362
Comments
@Brandjuh this is a Steam issue that happens to people with big inventories, ASF has a workaround in the code for that, but perhaps that workaround doesn't work anymore. Does it happen to you on usual basis? @ezhevita can you check if you can reproduce? Perhaps we need to increase our delay or add a semaphore there to avoid such issues. |
I've grepped my logs and I've observed this behavior only once in about two months in this pattern (v6.0.8.7-based version):
So a disconnect followed by trying to send inventory, which is expected to fail. I can't reproduce this issue with v6.1.0.3-based version on my main account, more details would help |
Seems reasonable since ASF gives up on workaround retrying if disconnection happens in the middle of it. @Brandjuh can you send full log? |
That bot does not have a big inventory, between 1200 and 1500 items, so that should not be the problem?
|
This almost confirms that it's not our fetching logic that is wrong but concurrent access. Steam likely doesn't expect too many concurrent calls for this endpoint, which makes sense, as we already were working around duplicate requests before. Please check if build https://github.com/JustArchiNET/ArchiSteamFarm/actions/runs/12382917216 resolves this issue - simply download artifact for your platform from the bottom of the page and use it. If you confirm that build fixes your issue, then I'll be happy to schedule another pre-release for this. Thanks in advance! |
I copied the "ArchiSteamFarm" file to the server and restarted the bot. Feel free to ping me in a day if I forget to update you, I am pretty busy with work at the moment and can forget to report a update. I only notice some login problems, but seems related to steam. |
@Brandjuh ping as requested 🙂 |
I do not get the error message anymore, however I noticed that the I am running ASF on Raspberry with a arm64 structure but seems like the plugins are not working with this test version. Edit:
|
You get command not found because all official plugins fail to load, as stated in your log, that's irrelevant to this issue though, and should be fixed by you. I believe we can consider this issue fixed, thanks for feedback, I'll release version with a fix shortly 🙂 |
Discussed in #3361
Originally posted by Brandjuh December 17, 2024
Since one of the latest update's of ASF I am getting error mentioned below. I have multiple bots running and only 1 bot has this problem. I did update the .NET to the latest, so I am not sure if this is related to that.
I hope that someone can put me on the right track.
The text was updated successfully, but these errors were encountered: