Added the ability to change the text size #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tolsi
reviewed
Nov 19, 2016
| @@ -482,13 +485,13 @@ private void drawCircle(double centerX, double centerY, double radius, boolean u | |||
| graphics.drawOval(topLeft.getX(), topLeft.getY(), size.getX(), size.getY()); | |||
| } | |||
|
|
|||
| private void showText(double X, double Y, String text, boolean useAbsCoords) | |||
| private void showText(double X, double Y, String text, int size, boolean useAbsCoords) | |||
There was a problem hiding this comment.
как насчет обратной совместимости?
There was a problem hiding this comment.
Предлагаю переделать, добавив отдельную команду text_size, которая меняет текущий (для вывода) размер шрифта.
Тогда не страдает обратная совместимость клиентов.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавил возможность менять размер шрифта, уж очень он мелкий.
Нужно только подправить VisualClient, например в Java:
public void text(double x, double y, int size, String msg, Color color)
{
Formatter f = new Formatter();
sendCommand(f.format("text %1.1f %1.1f %d %s %1.1f %1.1f %1.1f", x, y, size, msg, (float) color.getRed() / 255, (float) color.getGreen() / 255, (float) color.getBlue() / 255).toString());
}
А в MyStrategy использовать так:
vc.text(nextWaypoint.getX(), nextWaypoint.getY(), 35, "Next waypoint", Color.BLUE);