Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass thought return code of helm run as a exit code of plugin #45

Merged
merged 3 commits into from
Jan 22, 2022

Conversation

gyrter
Copy link

@gyrter gyrter commented Jan 21, 2022

Description

The plugin does not handle helm error. Helm vault lint exit code is always 0. This PR fix helm vault lint for CI/CD.

Fixes #46

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

  • Python Version: 3.9.5
  • Vault Version: 1.5.2

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Mentions:

@Just-Insane

@Just-Insane Just-Insane merged commit 072c601 into Just-Insane:master Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exit with non-zero exit code if helm exited with non-zero code
2 participants