Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request for pyez release 2.6.4 #1181

Merged
merged 11 commits into from
Jun 9, 2022
Merged

Pull request for pyez release 2.6.4 #1181

merged 11 commits into from
Jun 9, 2022

Conversation

chidanandpujar
Copy link
Collaborator

What does this PR do?

Pull request for pyez release 2.6.4

What issues does this PR fix or reference?
Release 2.6.4
Enhancements done
Supported start_shell options to choose the shell types (sh or csh) #995
Bugs Fixed
Fixed Device facts current_re returns the SRX cluster node0 and node1 details with cluster ID 16 #1135
Fixed upgrade ncclient version 0.6.13, updated requirements.txt to install ncclient==0.6.13 #1153
Fixed deprecation warning due to invalid escape sequences #1034
Fixed Unit tests test_sw_put_ftp failure #1165

Tests written?

Yes/No

@chidanandpujar chidanandpujar requested a review from ydnath June 8, 2022 12:30
Copy link
Collaborator

@dineshbaburam91 dineshbaburam91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comment

INSTALL-RHEL.md Outdated
##### For Python 3.x:
###### For RHEL:

#### Step 1: Install Junos PyEZ
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be step 2, right ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, updated

Step 2: Install Junos PyEZ

Development code can be installed directly from GitHub based on any branch, commit, or tag.

***Steps 1 -2 are still required.***
#### Alternate Step 4: Install Junos PyEZ from GitHub
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take care of step no's. I don't find step 3.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the step no's


#### Step 1: Install Python and PIP

##### For Python 3.x:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installation steps are missing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dnf install python3-pip

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dnf install python3-pip python3-wheel


##### For Python 3.x:
###### For RHEL:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

RELEASE-NOTES.md Outdated
- Fixed upgrade ncclient version 0.6.13, updated requirements.txt to install ncclient==0.6.13 #1153
- Fixed deprecation warning due to invalid escape sequences #1034
- Fixed Unit tests test_sw_put_ftp failure #1165
- Support for python 3.9
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add it in Features added list

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated .

Features Added

INSTALL-RHEL.md Outdated

The following are instructions for setting up a system starting from a stock system images.

These instructions were tested on a 64-bit systems from https://github.com/opscode/bento, and using the _Junos PyEZ_ library version 2.6.3.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it 2.6.3 or 2.6.4 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated it to 2.6.4

INSTALL-RHEL.md Outdated
#### Alternate Step 4: Install Junos PyEZ from GitHub

#### Step 4a: Install Git from OS packages
pip install git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip3

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip3 install git

INSTALL-RHEL.md Outdated
#### Step 4b: Install Junos PyEZ from GitHub

##### For Python 3.x:
pip install git+https://github.com/Juniper/py-junos-eznc.git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chidanandpujar chidanandpujar merged commit e6e0586 into Juniper:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants